Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change method of getting version from setup.py to package.xml #177

Merged
merged 8 commits into from
Mar 13, 2024
Merged

feat: change method of getting version from setup.py to package.xml #177

merged 8 commits into from
Mar 13, 2024

Conversation

h-suzuki-isp
Copy link
Contributor

@h-suzuki-isp h-suzuki-isp commented Mar 5, 2024 •
edited by ymski
Loading

Description

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-suzuki-isp h-suzuki-isp changed the title update: change method of getting version from setup.py to package.xml feat: change method of getting version from setup.py to package.xml Mar 5, 2024
@ymski
Copy link
Contributor

ymski commented Mar 6, 2024 •
edited
Loading

@h-suzuki-isp
It seems to be working well. For a better fix, check the following comments.

  • Package.xml is referenced when obtaining version information. When extracting version information from package.xml, you may want to consider using xml.etree.ElementTree instead of text analysis.

  • You may need to add <exec_depend>ament_index_python</exec_depend> to package.xml.

@h-suzuki-isp
Update: using xml.etree.ElementTree
1b29853 
Signed-off-by: h-suzuki <[email protected]>
@h-suzuki-isp
Fix: code style
1d32d27 
Signed-off-by: h-suzuki <[email protected]>
@h-suzuki-isp
Fix: code style
b0353ec 
Signed-off-by: h-suzuki <[email protected]>
@h-suzuki-isp
Fix: code style
a972e73 
Signed-off-by: h-suzuki <[email protected]>
ymski
ymski reviewed Mar 8, 2024
View reviewed changes
ros2caret/verb/version.py Outdated Show resolved Hide resolved
@h-suzuki-isp
Update: error message
eefec83 
Signed-off-by: h-suzuki <[email protected]>
@h-suzuki-isp h-suzuki-isp mentioned this pull request Mar 8, 2024
Closed
6 tasks
ymski
ymski reviewed Mar 11, 2024
View reviewed changes
ros2caret/verb/version.py Outdated Show resolved Hide resolved
ymski
ymski approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-suzuki-isp h-suzuki-isp merged commit ca1dc76 into tier4:main Mar 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymski ymski ymski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-suzuki-isp @ymski